Update escriptize hook to work with newer Windows versions#2964
Merged
ferd merged 1 commit intoerlang:mainfrom Jul 23, 2025
Merged
Update escriptize hook to work with newer Windows versions#2964ferd merged 1 commit intoerlang:mainfrom
ferd merged 1 commit intoerlang:mainfrom
Conversation
ferd
force-pushed
the
debug-broken-windows-builds
branch
2 times, most recently
from
7b2b7e0 to
f206a87
Compare
ferd
changed the title
The arch line changed from containing win32 to containing windows in rebar_utils:get_arch() so to keep things working (and fix CI/CD) by providing the Rebar3 executables in the root project path, we have to update the regex.
ferd
force-pushed
the
debug-broken-windows-builds
branch
from
ec478b0 to
86618e8
Compare
tsloughter
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arch line changed from containing
win32to containingwindowsinrebar_utils:get_arch()so to keep things working (and fix CI/CD) by providing the Rebar3 executables in the root project path, we have to update the regex.