Crypto library C code converted to C++14 with focus on FIPS and algorithm probing#11011
Open
kvakvs wants to merge 12 commits intoerlang:maintfrom
Open
Crypto library C code converted to C++14 with focus on FIPS and algorithm probing#11011kvakvs wants to merge 12 commits intoerlang:maintfrom
kvakvs wants to merge 12 commits intoerlang:maintfrom
Conversation
Contributor
CT Test Results 2 files 14 suites 4m 41s ⏱️ For more details on these failures, see this check. Results for commit 55f1a6e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/cryptofrom C89 to C++14 and modernizes some code aspects to make it safer and cleaner (research was done to find that this will be supported on oldest systems still used in testing lab)Changes
structandenumin typenames is not necessary. IntegerNULLbecome appropriately typednullptrstatic_cast(for simple conversions),const_cast(for adding or removing const qualifier), andreinterpret_cast(for incompatible value type changes)for (auto &p: array_name) {}bool-type bitfields#pragma oncesupported for a very long time by all compilersconstexprorINLINEfunctions