kernel: Fix inet6_sctp:peeloff_opts wrong socket#11007
Open
mhssler wants to merge 1 commit intoerlang:masterfrom
Open
kernel: Fix inet6_sctp:peeloff_opts wrong socket#11007mhssler wants to merge 1 commit intoerlang:masterfrom
mhssler wants to merge 1 commit intoerlang:masterfrom
Conversation
peeloff_opts/2 in inet6_sctp called prim_inet:setopts(S, Opts) instead of prim_inet:setopts(NewS, Opts). This caused the peeled-off socket to not inherit options from the parent socket. The IPv4 variant in inet_sctp was correct.
Contributor
CT Test Results 2 files 74 suites 1h 13m 2s ⏱️ For more details on these failures, see this check. Results for commit 5529e7d. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
peeloff_opts/2 in inet6_sctp called prim_inet:setopts(S, Opts) instead of prim_inet:setopts(NewS, Opts). This caused the peeled-off socket to not inherit options from the parent socket. The IPv4 variant in inet_sctp was correct.