Reject hamt duplications in enif_make_map_from_arrays

[nickva]

Previously enif_make_map_from_arrays did not reject duplicates for hamt maps (those with greater than 32 keys) as the API indicated. Instead, it would return a hamt map that might not match against a map built from the same key-value pair set in Erlang.

It turns out that the internal hamt building call already takes a reject_dupkeys argument, it was just always set to 0, so to fix the issue we thread the parameter through, so that enif_make_map_from_arrays when it constructs the hamt object, always sets reject_dupkeys=1.

Fix #10975

[github-actions]

CT Test Results

    3 files    136 suites   50m 46s ⏱️
1 675 tests 1 619 ✅ 56 💤 0 ❌
2 317 runs  2 243 ✅ 74 💤 0 ❌

Results for commit a52bc0f.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

• Complete CT logs (Download Logs)
• HTML Documentation (Download HTML Docs)
• Windows Installer

// Erlang/OTP Github Action Bot

[sverker]

Thanks for the report and fix. I pushed a fixup that instead makes erts_map_from_ks_and_vs consistent and always reject duplicates regardless of map size.

[nickva]

Thank you, Sverker, that's a much better fix!

[sverker]

I squashed our two commits and rebased it back onto patch-base-26 with a forward merge to patch-base-27 to solve a conflict. Now the same fix can be released on 26, 27, 28 and 29.