Open
Conversation
Contributor
CT Test Results 2 files 66 suites 27m 34s ⏱️ For more details on these failures, see this check. Results for commit 2874863. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
dgud
force-pushed
the
dgud/ssl/move-options/OTP-19967
branch
from
4b540f3 to
1d83139
Compare
IngelaAndin
requested changes
Apr 2, 2026
dgud
force-pushed
the
dgud/ssl/move-options/OTP-19967
branch
from
1d83139 to
86d962b
Compare
IngelaAndin
reviewed
Apr 7, 2026
IngelaAndin
requested changes
Apr 7, 2026
Do not start the socket handling processes with the args including the user options, send them to the process afterwards. Otherwise the supervisor will store the "unused" options in its state, which can be quite large, which may include a lot of certs and keys.
dgud
force-pushed
the
dgud/ssl/move-options/OTP-19967
branch
from
86d962b to
2874863
Compare
Contributor
Author
|
Removed the monitor, not needed. And Renamed Parent to ConnSup |
IngelaAndin
approved these changes
Apr 8, 2026
Contributor
IngelaAndin
left a comment
IngelaAndin
left a comment
There was a problem hiding this comment.
Yes I think this looks good now, and after renaming my misunderstanding of the solution is cleared up .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not start the socket handling processes with the args including the user options, send them to the process afterwards.
Otherwise the supervisor will store the "unused" options in its state, which can be quite large, which may include a lot of certs and keys.