Add Rosé Pine theme support and installation guide for bluefin-cosmic-dx - #32
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds end-user theming and onboarding documentation for the bluefin-cosmic-dx image, including a new ujust command set to apply the Rosé Pine theme across COSMIC and related tools, plus bilingual installation guides and README updates to point users to those docs.
Changes:
- Add
ujusttheming commands to install/apply/update/uninstall Rosé Pine (COSMIC desktop/terminal, Starship, Warp, Zen, cursors) and configure Vicinae for COSMIC. - Add bilingual installation guides (EN + PT-BR) describing ISO install +
bootc switchrebase workflow. - Update README (EN + PT-BR) with an “Installation” section and improved variant table formatting.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds Installation section linking to docs and reformats variants table. |
| README.pt-BR.md | Adds Instalação section linking to docs and reformats variants table. |
| docs/installation.md | New English step-by-step installation + rebase guide. |
| docs/instalacao.md | New Portuguese (PT-BR) step-by-step installation + rebase guide. |
| custom/ujust/custom-cosmic-theme.just | New ujust commands to install/apply/update/uninstall Rosé Pine theming and configure Vicinae for COSMIC. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e48ff5962
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Fix grep pipeline in find_zen_profile to not fail with pipefail when profiles.ini has no Path= line - Bake COSMIC_DATA_CONTROL_ENABLED=1 into image at build time in 30-cosmic-desktop.sh instead of trying to edit read-only /usr/share at runtime - Replace sudo sed on system desktop file with writable user-level session override in ~/.local/share/wayland-sessions/ - Remove only known theme files (userChrome.css, userContent.css) in Zen uninstall instead of rm -rf the entire chrome/ directory - Update PR description to remove VHDX mention not in scope
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Suppressed comments (12)
custom/ujust/custom-cosmic-theme.just:373
- Same concern as
setup-rose-pine-starship: updating from a mutablemainbranch in a personal repo is non-reproducible and can unexpectedly change user config. Prefer pinning to a commit/tag or shipping the theme file in-repo.
curl -fsSL --max-time 15 \
-o "$HOME/.config/starship.toml" \
"https://raw.githubusercontent.com/ericrocha97/starship/main/rose-pine.toml"
docs/instalacao.md:59
- Para manter consistência com outras instruções do repo, inclua
--transport registryneste exemplo debootc switchpara deixar explícito que a imagem vem de um registry.
sudo bootc switch ghcr.io/ericrocha97/bluefin-cosmic-dx-nvidia:stable
docs/installation.md:59
- For consistency with other repo instructions, include
--transport registryin thisbootc switchexample so it’s explicit the image is pulled from a registry.
sudo bootc switch ghcr.io/ericrocha97/bluefin-cosmic-dx-nvidia:stable
build/30-cosmic-desktop.sh:115
- The sed replacement assumes the Exec line is exactly
Exec=/usr/bin/start-cosmic. If upstream changes that desktop entry (extra args, different path), this will silently not modify anything and then hard-fail the build. Use a more flexible match on the Exec line containingstart-cosmicand fail with a clearer error only if no such Exec line exists.
sed -i \
's#Exec=/usr/bin/start-cosmic#Exec=env COSMIC_DATA_CONTROL_ENABLED=1 /usr/bin/start-cosmic#' \
"${COSMIC_DESKTOP_FILE}"
if grep -q "COSMIC_DATA_CONTROL_ENABLED=1" "${COSMIC_DESKTOP_FILE}"; then
log_success "COSMIC_DATA_CONTROL_ENABLED=1 enabled in ${COSMIC_DESKTOP_FILE}"
custom/ujust/custom-cosmic-theme.just:392
setup-rose-pine-warpinstalls the Warp theme under${XDG_DATA_HOME:-$HOME/.local/share}, butupdate-rose-pine-allassumes~/.local/share. IfXDG_DATA_HOMEis set, updates will miss the installed theme.
echo "==> Updating Warp theme (git pull)"
WARP_THEME_DIR="$HOME/.local/share/warp-terminal/themes/rose-pine-warp"
if [[ -d "$WARP_THEME_DIR/.git" ]]; then
custom/ujust/custom-cosmic-theme.just:450
uninstall-rose-pine-allremoves the Warp theme only from~/.local/share, but installation may have used$XDG_DATA_HOME. This can leave the theme behind on systems with a non-default XDG data dir.
echo "Removing Warp theme..."
rm -rf "$HOME/.local/share/warp-terminal/themes/rose-pine-warp"
custom/ujust/custom-cosmic-theme.just:302
- This user-level COSMIC session override relies on an exact
Exec=/usr/bin/start-cosmicmatch and also doesn't guard against$SYSTEM_DESKTOPmissing before callingsed(which will abort due toset -e). Make the substitution match any Exec line containingstart-cosmicand fail with a clearer message if the source desktop entry is missing.
echo "Creating user-level session override..."
mkdir -p "$(dirname "$USER_DESKTOP")"
sed 's#Exec=/usr/bin/start-cosmic#Exec=env COSMIC_DATA_CONTROL_ENABLED=1 /usr/bin/start-cosmic#' \
"$SYSTEM_DESKTOP" > "$USER_DESKTOP"
if grep -q "COSMIC_DATA_CONTROL_ENABLED=1" "$USER_DESKTOP"; then
custom/ujust/custom-cosmic-theme.just:17
- This downloads the Starship theme from a mutable branch (
main) in a personal repository. That creates a supply-chain risk (content can change without review) and makes the setup non-reproducible. Consider pinning to a specific commit/tag or vendoring the theme file into this repo and copying it locally.
This issue also appears on line 371 of the same file.
curl -fsSL --max-time 15 \
-o "$HOME/.config/starship.toml" \
"https://raw.githubusercontent.com/ericrocha97/starship/main/rose-pine.toml"
README.md:80
- The rebase commands here omit the reboot step, so users may think the switch is complete when it won’t take effect until restart. Also, other repo docs recommend specifying
--transport registryfor clarity/consistency when switching to a remote image.
# Standard (Intel/AMD GPUs, VMs)
sudo bootc switch ghcr.io/ericrocha97/bluefin-cosmic-dx:stable
# NVIDIA (RTX GPUs)
sudo bootc switch ghcr.io/ericrocha97/bluefin-cosmic-dx-nvidia:stable
README.pt-BR.md:80
- Os comandos de rebase aqui não incluem reinicialização; o
bootc switchsó entra em efeito após reboot, então isso pode confundir quem está instalando. Além disso, outros docs do repo usam--transport registrypara deixar explícito que é um switch via registry.
# Padrão (GPUs Intel/AMD, VMs)
sudo bootc switch ghcr.io/ericrocha97/bluefin-cosmic-dx:stable
# NVIDIA (GPUs RTX)
sudo bootc switch ghcr.io/ericrocha97/bluefin-cosmic-dx-nvidia:stable
docs/installation.md:53
- For consistency with other repo instructions, include
--transport registryin thisbootc switchexample so it’s explicit the image is pulled from a registry.
This issue also appears on line 59 of the same file.
sudo bootc switch ghcr.io/ericrocha97/bluefin-cosmic-dx:stable
docs/instalacao.md:53
- Para manter consistência com outras instruções do repo, inclua
--transport registryneste exemplo debootc switchpara deixar explícito que a imagem vem de um registry.
This issue also appears on line 59 of the same file.
sudo bootc switch ghcr.io/ericrocha97/bluefin-cosmic-dx:stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Este PR adiciona o tema Rosé Pine completo para o ambiente COSMIC (terminal, prompt, cursores e apps) e guias de instalação bilíngues (EN + PT-BR).
Changes
custom/ujust/custom-cosmic-theme.justcom suporte completo ao tema Rosé Pine Moon para COSMIC Desktop, Starship prompt, terminal Warp, navegador Zen e cursores (+457 linhas)docs/installation.md(EN) edocs/instalacao.md(PT-BR) com passo a passo para primeira instalação e rebase via bootc (98 linhas cada)Testing
Checklist