feat: tornar imagem COSMIC-only e unificar notificação do n8n - #28
Conversation
… configurações de usuário no disk.toml
…zar scripts de notificação
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c80be4649a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…enciais padrão no README e disk.toml
|
@copilot revise essa PR, resolva o conflito pendente, garanta que a implementacao esteja ok |
|
@copilot revise essa PR, resolva o conflito pendente, garanta que a implementacao esteja ok |
Conflito com Também revisei a implementação e validei o que era aplicável neste ambiente:
No GitHub Actions, o último failure anterior era do job dinâmico do Copilot por modelo indisponível ( |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 21 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
iso/disk.toml:10
iso/disk.tomlnow bakes in a well-known default password ("user"). Even with the README warning, this increases the risk of someone distributing QCOW2/RAW artifacts with trivial credentials. Consider defaulting to a locked account/no password in-repo and documenting a local override (or requiring the user to set a password hash before building artifacts).
# Default local VM login password is "user" (SHA-512 hash below).
# Change this hash for your own local testing before distributing artifacts.
password = "$6$zTtLrcd2ocxh3WdL$Nyw/OT9D6Erg.9LN11aSlIMQVCFZgwrJUDkiwJjye.H5zjPZAK7UjBXK.AK2uKocZd4nrE2p3zcShTjuRwk9o."
|
@copilot resolva todas as reviews feitas |
Assisted-by: GPT-5 via GitHub Copilot
Resolvi os feedbacks pendentes no commit
Validação executada:
Também conferi CI no GitHub Actions: os checks de PR atuais estão verdes; a falha antiga era do job dinâmico do Copilot por modelo indisponível. |
|
@copilot Fix the code for all comments in this review thread. When a review comment includes a suggested change, apply the suggestion exactly. Do not make changes beyond what is described in the linked review thread. |
Aplicado no commit
Validação executada: |
Assisted-by: deepseek-v4-pro via opencode
Summary
cosmic-greeter, incluindo novo scriptbuild/40-remove-gnome.shJenkinsfilepara notificar o n8n uma única vez nopost { always { ... } }, removendo retries nonotify_n8n.sh, e adicionar workflow do GitHub para rodar a suíteci/jenkins/tests/run-all.shValidation
bash ci/jenkins/tests/run-all.shshellcheck build/15-system-optimizations.sh build/30-cosmic-desktop.sh build/40-remove-gnome.sh ci/jenkins/tests/test_cosmic_only_scripts.sh ci/jenkins/tests/run-all.shjust --list