Fix (most of) compilation warnings#85
Merged
anderslindho merged 7 commits intoepics-modules:masterfrom Nov 20, 2025
Merged
Conversation
cf41cf3 to
b8f1d5e
Compare
anderslindho
approved these changes
Nov 18, 2025
tmpnam can lead to race conditions where temporary file is opened by another process in the time between tmpnam and fopen calls. This change requires slight modification in do_asVerify as it now needs to accept either file name or a file pointer returned by tmpfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to clean up warnings.
Warnings still left to clean up:
Happens only with base 3.15, where
iocshSetErrordoesn't seem to exist. I'm not entirely sure why it doesn't fail the build instead.Fixing this would require either some heavy-ish refactoring of
concatenate_pathsor providing it with the size ofdestbuffer.