#6429 - Selection works wrong for line symbol and for phosphate#9680
Open
bekaChaduneli wants to merge 1 commit intomasterfrom
Open
#6429 - Selection works wrong for line symbol and for phosphate#9680bekaChaduneli wants to merge 1 commit intomasterfrom
bekaChaduneli wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Fixed unintended selection highlight appearing on blank space blocks below line (
-) andPsymbols in Sequence Layout Mode.Root cause:
In a two-stranded chain (e.g., loaded via HELM with
RNA1,RNA2,2:pair-2:pair), each rendered position is backed by atwoStrandedNodecontaining both a sense and an antisense slot. When clicking a sense node such as aBackBoneSequenceNode(-), its underlying monomer'sselectedflag is set totrue. The antisense slot for that position is rendered as anEmptySequenceNode— but because it shares the same monomer,this.node.monomer.selectedwas alsotrue, causingdrawSelection()to callappendSelection()and inject a green<rect fill="#57FF8F">into the empty placeholder below.Changes made:
BaseSequenceItemRenderer.tsdrawSelection()— Added an early-return guard: ifthis.nodeis an instance ofEmptySequenceNodeorBackBoneSequenceNode,removeSelection()is called immediately and the method returns, preventing any selection rectangle from being appended to structural placeholder nodes.Visual states after the fix:
MonomerSequenceNode/Nucleotideetc.trueBackBoneSequenceNode(-)true(shared)EmptySequenceNode(blank antisense slot)true(shared)Check list
#1234 – issue name