Skip to content

#9634 - refactor: convert server.js to TypeScript with prop types validation#9679

Open
sabaPailodze wants to merge 1 commit intomasterfrom
9634-Refactor-Variables-are-missing-in-props-validation-(let's-rewrite-JS-to-TS)-52
Open

#9634 - refactor: convert server.js to TypeScript with prop types validation#9679
sabaPailodze wants to merge 1 commit intomasterfrom
9634-Refactor-Variables-are-missing-in-props-validation-(let's-rewrite-JS-to-TS)-52

Conversation

@sabaPailodze
Copy link
Copy Markdown
Collaborator

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Changes

  • Renamed server.jsserver.ts
  • Defined types for all props and callback parameters
  • No new types added - reused existing UiAction from action.types.ts

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: Variables are missing in props validation (let's rewrite JS to TS) 52

1 participant