Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Fix: Library preview persists after unfavoriting from Favorites
Issue: After removing a monomer or RNA preset from Favorites via the star, the library structure preview sometimes stayed visible.
Cause: Preview opens via a 500 ms debounced
showPreviewinMonomerGroup/RnaPresetGroup. Unfavoriting unmounts the card without a reliablemouseleave, so the usual clear path does not run; a pending debounced call can still fire and restore the preview. Clearing Redux alone does not cancel that debounce (andhidePreviewdoes not cancel the library groups’ debouncer).Fix:
closeLibraryPreview(cancel debounce +showPreview(undefined)) is passed asonStarClickfrom each group.MonomerItem/RnaPresetItemcallonStarClickat the start ofaddFavorite, beforetoggleMonomerFavorites/togglePresetFavorites.Tests: Star click invokes
onStarClickinMonomerItem.test.tsxandRnaPresetItem.test.tsx.Changed:
MonomerGroup.tsx,MonomerItem.tsx,RnaPresetGroup.tsx,RnaPresetItem.tsx,RnaPresetItem/types.ts, plus the two tests above.screen-capture.1.webm
Check list
#1234 – issue name