Skip to content

#9624 - Refactor: Variables are missing in props validation (let's rewrite JS to TS) 42#9658

Merged
AlexeyGirin merged 1 commit intomasterfrom
9624-refactor-variables-are-missing-in-props-validation-42
Apr 3, 2026
Merged

#9624 - Refactor: Variables are missing in props validation (let's rewrite JS to TS) 42#9658
AlexeyGirin merged 1 commit intomasterfrom
9624-refactor-variables-are-missing-in-props-validation-42

Conversation

@mariam-khutuashvili
Copy link
Copy Markdown
Collaborator

@mariam-khutuashvili mariam-khutuashvili commented Apr 3, 2026

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

  • Convert refrag.js to TypeScript (.ts) with full type definitions
  • Add typed class field item: Fragment and typed constructor parameter
  • Type all method parameters using existing Render, ReStruct, Fragment, and Box2Abs types
  • Add optional chaining for Map.get() calls to handle potential undefined
  • No any used — all types are explicit

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@AlexeyGirin AlexeyGirin merged commit 370d780 into master Apr 3, 2026
14 of 15 checks passed
@AlexeyGirin AlexeyGirin deleted the 9624-refactor-variables-are-missing-in-props-validation-42 branch April 3, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: Variables are missing in props validation (let's rewrite JS to TS) 42

3 participants