Skip to content

#9623 - Refactor: Variables are missing in props validation (let's rewrite JS to TS) 41#9649

Closed
mariam-khutuashvili wants to merge 1 commit intomasterfrom
9623-refactor-variables-are-missing-in-props-validation-41
Closed

#9623 - Refactor: Variables are missing in props validation (let's rewrite JS to TS) 41#9649
mariam-khutuashvili wants to merge 1 commit intomasterfrom
9623-refactor-variables-are-missing-in-props-validation-41

Conversation

@mariam-khutuashvili
Copy link
Copy Markdown
Collaborator

@mariam-khutuashvili mariam-khutuashvili commented Apr 2, 2026 •
edited
Loading

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

  • Convert redatasgroupdata.js to TypeScript (.ts) with full type definitions
  • Add typed class field sgroup: SGroup and typed constructor parameter
  • Type all method parameters using existing Render, ReStruct, and SGroup types
  • No any used — all types are explicit

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

@mariam-khutuashvili mariam-khutuashvili self-assigned this Apr 2, 2026
@auto-assign auto-assign bot requested a review from rrodionov91 April 2, 2026 07:20
@mariam-khutuashvili mariam-khutuashvili linked an issue Apr 2, 2026 that may be closed by this pull request
Refactor: Variables are missing in props validation (let's rewrite JS to TS) 41 #9623
Closed
@mariam-khutuashvili mariam-khutuashvili force-pushed the 9623-refactor-variables-are-missing-in-props-validation-41 branch from b25e4aa to fd08458 Compare April 3, 2026 05:42
@mariam-khutuashvili mariam-khutuashvili force-pushed the 9623-refactor-variables-are-missing-in-props-validation-41 branch from fd08458 to 33fb5d0 Compare April 3, 2026 07:44
@AlexeyGirin AlexeyGirin closed this Apr 3, 2026
@AlexeyGirin AlexeyGirin reopened this Apr 3, 2026
@mariam-khutuashvili mariam-khutuashvili deleted the 9623-refactor-variables-are-missing-in-props-validation-41 branch April 3, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrodionov91 rrodionov91 Awaiting requested review from rrodionov91

@svvald svvald Awaiting requested review from svvald

Assignees

@mariam-khutuashvili mariam-khutuashvili

Labels

Fixed by ChatGPT5 Ready for approve

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor: Variables are missing in props validation (let's rewrite JS to TS) 41

2 participants

@mariam-khutuashvili @AlexeyGirin