Skip to content

#9529 - Refactor: Remove unnecessary type assertions#9530

Open
sonozyurt wants to merge 1 commit intomasterfrom
9529-refactor-this-assertion-is-unnecessary-since-it-does-not-change-the-type-of-the-expression
Open

#9529 - Refactor: Remove unnecessary type assertions#9530
sonozyurt wants to merge 1 commit intomasterfrom
9529-refactor-this-assertion-is-unnecessary-since-it-does-not-change-the-type-of-the-expression

Conversation

@sonozyurt
Copy link
Collaborator

@sonozyurt sonozyurt commented Mar 24, 2026

How the feature works? / How did you fix the issue?

This PR removes unnecessary type assertions across the codebase that do not change the expression type, addressing code quality issues identified by SonarQube.

Changes:

  • Removed unnecessary as type assertions in actionmenu.tsx where the type was already correctly inferred
  • Removed redundant type assertions in sdata.ts modal state management

These changes improve code clarity without affecting functionality, as the assertions were redundant (the compiler already knew the correct types).

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

Co-Authored-By: Claude (claude-4-5-sonnet) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: This assertion is unnecessary since it does not change the type of the expression

1 participant