Draft
Conversation
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
astsiapanay
reviewed
Mar 25, 2026
|
|
||
| Buffer requestBody = context.getRequestBody(); | ||
| proxyRequest.putHeader(HttpHeaders.CONTENT_LENGTH, Integer.toString(requestBody.length())); | ||
| context.getRequestHeaders().forEach(proxyRequest::putHeader); |
Collaborator
There was a problem hiding this comment.
why did you remove the line?
Contributor
Author
There was a problem hiding this comment.
It didn't do anything. I removed the field.
| if (!Strings.CI.contains(contentType, Proxy.HEADER_CONTENT_TYPE_APPLICATION_JSON)) { | ||
| return respond(HttpStatus.UNSUPPORTED_MEDIA_TYPE, "Only application/json is supported"); | ||
| } | ||
| return proxy.getTaskExecutor().submit(() -> { |
Collaborator
There was a problem hiding this comment.
you don't need to run the block asynchronously.
| context.getRequest().body() | ||
| .compose(body -> { | ||
| log.info("Received body from client. Length: {}", body.length()); | ||
| return proxy.getTaskExecutor().submit(() -> parseBody(body)); |
|
|
||
| private void sendRequest() { | ||
| UpstreamRoute route = context.getUpstreamRoute(); | ||
| try { |
Collaborator
There was a problem hiding this comment.
the block should be in a separate method.
| Buffer responseBody = context.getResponseStream().getContent(); | ||
| context.setResponseBody(responseBody); | ||
| context.setResponseBodyTimestamp(System.currentTimeMillis()); | ||
| Future<TokenUsage> tokenUsageFuture = collectTokenUsage(responseBody); |
Collaborator
There was a problem hiding this comment.
I'm not sure the method supports collecting token usage for responses API
Contributor
Author
There was a problem hiding this comment.
It does. At least structurally, the usage section is similar and contains information that was previously available. I’ve updated the aliases to pick up the new field names.
https://developers.openai.com/api/reference/resources/responses#(resource)%20responses%20%3E%20(model)%20response_usage%20%3E%20(schema)
| if (result.failed()) { | ||
| log.warn("Failed to collect token usage", result.cause()); | ||
| } | ||
| return collectResponseAttachments(responseBody); |
Collaborator
There was a problem hiding this comment.
the same thing for collecting attachments from responseAPI response
| context.getResponse().reset(); // drop connection, so that partial client response won't seem complete | ||
| log.warn("Can't send response to client. Error:", error); | ||
| Deployment deployment = context.getDeployment(); | ||
| if (deployment instanceof Model) { |
Collaborator
There was a problem hiding this comment.
This block should be revised for response API because it's tied to collecting token usage.
| public enum RouteTemplate { | ||
|
|
||
| // OpenAI API routes | ||
| RESPONSES( |
Collaborator
There was a problem hiding this comment.
I would rename to something meaningful at least LLM_RESPONSES_API
response is vague.
| .map(apiKeyData -> new AuthorizationResult(apiKeyData, null)); | ||
| } | ||
|
|
||
| if (apiKey == null && authorization.startsWith("Bearer ")) { |
Collaborator
There was a problem hiding this comment.
That may break authN flow for another IdP like Google. They send an opaque token instead of JWT.
| return new ProxyContext(proxy, config, request, newApiKeyData, extractedClaims, traceId, spanId, traceFlags); | ||
| } | ||
|
|
||
| public Future<HttpClientRequest> createProxyRequest(Function<Deployment, String> endpointSelector) { |
Collaborator
There was a problem hiding this comment.
I would move to BaseDeploymentController instead of making them available for any controller.
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial support for Responses API.