fix: Support dynamic redirect_uri in Toolset OAuth signin flow#1418
Open
DmytroZaichenkoDev wants to merge 8 commits intodevelopmentfrom
Open
fix: Support dynamic redirect_uri in Toolset OAuth signin flow#1418DmytroZaichenkoDev wants to merge 8 commits intodevelopmentfrom
DmytroZaichenkoDev wants to merge 8 commits intodevelopmentfrom
Conversation
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
DmytroZaichenkoDev
requested review from
alexey-ban,
nepalevov and
tataranovich
as code owners
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
credentials/src/main/java/com/epam/aidial/core/credentials/service/TokenService.java
Outdated
Show resolved
Hide resolved
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
…against allowedRedirectUris property
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
Contributor
Dependency ReviewThe following issues were found:
License Issuessettings.gradle
OpenSSF Scorecard
Scanned Files
|
astsiapanay
reviewed
Mar 26, 2026
| String requestRedirectUri = resourceSignInRequest.getRedirectUri(); | ||
|
|
||
| if (StringUtils.isNotBlank(requestRedirectUri)) { | ||
| List<String> effectiveAllowedUris = getEffectiveAllowedUris(resourceAuthSettings); |
Collaborator
There was a problem hiding this comment.
It doesn't make sense to build a new list and check if the url is presented there.
just allowed.contains()
| } | ||
|
|
||
| private List<String> collectRedirectUris(ResourceAuthSettings resourceAuthSettings) { | ||
| return RedirectUriHelper.collectAllowedRedirectUris(allowedRedirectUris, resourceAuthSettings); |
Collaborator
There was a problem hiding this comment.
I think the more simple way is just to create a hashed set and add the url there.
If the list is relatively small. ArrayList works even better.
| import java.util.List; | ||
|
|
||
| @UtilityClass | ||
| public class RedirectUriHelper { |
Collaborator
There was a problem hiding this comment.
I think we don't need the helper any longer
| */ | ||
| private ResourceAuthSettingsValidationFields getOauthWithDynamicRegistrationValidationFields() { | ||
| return ResourceAuthSettingsValidationFields.builder() | ||
| .requiredFields(Set.of(ResourceAuthSettingsField.REDIRECT_URI)) |
Collaborator
There was a problem hiding this comment.
Why is redirect uri not required any longer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable issues
Description of changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.