Fix: use encoding= keyword for open() in ccmx.py - #973
Open
ahjulstad wants to merge 1 commit into
Open
Conversation
Generated with AI assistance by goose (AAIF). Changed open(path, "utf8") to open(path, encoding="utf8") in convert_devicecorrections_to_ccmx(). The positional argument "utf8" was being interpreted as the file mode, not the encoding. On Python 3.14 this raises a ValueError due to stricter mode validation.
|
Makes sense to me even if it's something rather trivial for LLM-assistance. |
Author
I know, I just wanted to flag it. |
|
can confirm this, I was experiencing the UI giving me an error when trying to import the corrections and this change is what fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated with AI assistance by goose (AAIF).
Problem
convert_devicecorrections_to_ccmx()inDisplayCAL/ccmx.pycalledopen(path, "utf8")passing"utf8"as the file mode positional argument instead of as the encoding. On Python 3.14, which has stricter mode validation, this raises:This prevented importing iColorDisplay colorimeter corrections at startup.
Fix
Changed
open(path, "utf8")toopen(path, encoding="utf8").