[#901] Add pin/float button to Qt visual whitepoint editor controls panel - #908
Merged
Merged
Conversation
…anel, bump version to 3.10.0.dev62 Qt has no AUI-docking equivalent for wx's `PinButton(True)`-managed `mainPanel` pane, so `VisualWhitepointEditorWindow.float_panel()`/ `dock_panel()` detach the controls panel into a plain top-level `_FloatingControlsWindow` instead, toggled via a new pin button in the panel header. Closing the floating window docks the panel back rather than destroying it, mirroring wx's `close_pane_handler`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PinButton(True)-managedmainPanelpane, soVisualWhitepointEditorWindow.float_panel()/dock_panel()detach the controls panel into a plain top-level_FloatingControlsWindowinstead, toggled via a new pin button in the panel header row.close_pane_handler(which vetoes the close and docks instead).DisplayCAL/VERSIONto3.10.0.dev62.Closes #901.
Test plan
pytest tests/test_ui_main_window.py -k visual_whitepoint_editor(11 passed, includes 3 new pin/float tests)pytest tests/test_ui_main_window.py(539 passed, no regressions)