[#906] Fix wxAssertionError on Visual Whitepoint Editor close - #907
Merged
Conversation
…mp version to 3.10.0.dev60 `AuiManagerLRDocking` pushes itself as an event handler onto the managed frame and its children. `OnCloseWindow()` never called `self._mgr.UnInit()` to remove it, so wxWidgets asserted `GetEventHandler() == this` and crashed during app teardown when the editor window was destroyed.
eoyilmaz
force-pushed
the
906-wx-visual-whitepoint-editor-close-crash
branch
from
July 20, 2026 22:40
32bfc94 to
4fb8261
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VisualWhitepointEditorcreates anAuiManagerLRDockingwhich pushes itself as an event handler onto the managed frame/childrenOnCloseWindow()never calledself._mgr.UnInit(), so the pushed handler was still attached when the windows were destroyed, tripping wxWidgets'GetEventHandler() == thisassertion during app exitself._mgr.UnInit()inOnCloseWindow()(guarded, sinceself._mgronly exists whennot patterngenerator) beforeevent.Skip()Found while manually verifying the fix for #899. Fixes #906
Test plan
ast.parse)wxAssertionErroron exit