[#855] Add missing input-value clipping warning icon to Qt 3D LUT window - #883
Merged
Merged
Conversation
wx shows a warning-triangle icon (`dialog-warning.png`) next to the clipping-warning text in the 3D LUT window's TRC block. The Qt port only ever created and toggled the text `QLabel`, so the icon never appeared. Add a `QLabel` pixmap alongside it, sourced via `get_theme_pixmap()` (mirroring the same pattern already used in `measurement_report.py`), and toggle its visibility together with the label in `lut3d_show_input_value_clipping_warning()`. Bump version to 3.10.0.dev50.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QLabelpixmap sourced viaget_theme_pixmap(16, "dialog-warning")next to the clipping-warning text in_build_trc_block(), mirroring the same pattern already used inmeasurement_report.py.lut3d_show_input_value_clipping_warning().3.10.0.dev50.Closes #855
Test plan
DisplayCAL/ui/tools/lut3d.pyimports cleanly andget_theme_pixmap(16, "dialog-warning")resolves a non-null 16x16 pixmap under an offscreenQApplication.XYZbpout > XYZbpin, "Unmodified" selected, rendering intent not inla/p/pa/ms/s/lp) on a liveLUT3DWindowinstance and confirmed both the icon and label become visible.