[#849] Add Qt curve/LUT viewer action buttons - #878
Merged
Conversation
….dev47 Ports the actions present in wx_lut_viewer.py but missing from the Qt curve-viewer port: BPC apply, install/reload VCGT via dispwin, save the plot as an image or the vcgt as a .cal, advanced per-tag A2B/B2A shaper curves gated by show_advanced_options, and per-monitor auto-follow (the standalone window reloads a display's profile when dragged onto it). curve_data.py gains the toolkit-neutral helpers (apply_bpc(), install_vcgt(), reload_display_vcgt(), extract_shaper_curve()); the buttons and moveEvent() plumbing live in curve_viewer.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #849. Ports the actions present in
wx_lut_viewer.pybut missing from the Qt curve-viewer port (DisplayCAL/ui/tools/curve_viewer.py), found during the wx→Qt port-completeness audit:apply_bpc()), enabled only when the profile's vcgt has a lifted black point.install_vcgt()), runs Argylldispwinon a background thread.reload_display_vcgt())..bmp/.png/.jpg/.xbm/.xpm) and save-vcgt-as-.calbuttons.show_advanced_options, including the v2 Lab L*-encoding resample from the wx original.CurveViewerWindowreloads the new display's profile (or live LUT, if "show actual LUT" is on) when dragged onto another monitor, mirroring wx'smove_handler.DisplayCAL/ui/plot/curve_data.pygains the toolkit-neutral helpers; the buttons andmoveEvent()plumbing live incurve_viewer.py. BumpedDisplayCAL/VERSIONto3.10.0.dev47.Test plan
tests/test_ui_plot_curve_data.py(10 tests) coveringapply_bpc(),install_vcgt(),reload_display_vcgt(), andextract_shaper_curve()(including the Lab L* resample branch), all with stubbed Argyll/dispwincalls.tests/test_ui_curve_viewer.py(15 tests) covering vcgt-action-toolbar visibility/enablement, button click wiring (including exception reporting), save dialogs, shaper-curve mode listing/drawing, and per-monitorfollow_display().pytest tests/ -n auto— 2481 passed, 21 skipped, no regressions.ruff checkclean on both changed source files.python -m DisplayCAL.ui.tools.curve_viewerand exercised each button against a real cLUT test profile.