[#845] Reproduce the BPC choice dialog on Qt measurement-mode switch - #871
Merged
Merged
Conversation
Qt's measurement_mode_ctrl_handler() dropped the confirm-and-toggle black-point-correction prompt that wx's version shows when switching measurement modes implies BPC should also change, silently discarding the user's choice and its "don't ask again" persistence. Add _confirm_black_point_correction_choice() to reproduce it: a QMessageBox with turn-on/turn-off vs. keep-current buttons and a do-not-show-again checkbox, wired the same way wx's ConfirmDialog was.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
measurement_mode_ctrl_handler()silently dropped wx's confirm-and-toggle black-point-correction prompt (shown when a measurement-mode switch implies BPC should also toggle), including its "don't ask again" persistence._confirm_black_point_correction_choice(), aQMessageBoxport of wx'sConfirmDialogwith turn-on/turn-off vs. keep-current buttons and a do-not-show-again checkbox wired tocalibration.black_point_correction_choice.show.Fixes #845
Test plan
pytest tests/test_ui_main_window.py -q(501 passed)pytest tests/ -k "qt or ui" -q -n auto(955 passed, 2 skipped)