[#843] Port "Change patch order" sort/reorder feature to the Qt testchart editor - #868
Merged
Merged
Conversation
…hart editor Ports wx_testchart_editor.tc_sort_handler's 23 sort/reorder modes (gray/white/ primary-to-top, HSI/HSL/HSV/L/Rec.709-luma/RGB/BGR sorts, "minimize display response delay", and the interleave/checkerboard patterns), which the Qt port's own docstring explicitly flagged as deferred. Reuses the existing DisplayCAL.cgats.CGATS sort/checkerboard methods, so no new sorting logic was needed, only the missing UI wiring. Adds a change-patch-order combo box + Apply button to the same row as the "add reference patches" controls (matching wx's layout), gated on a loaded chart via the new `_update_sort_controls()`, and `tc_sort_handler()` which dispatches to the selected mode and refreshes the grid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wx_testchart_editor.tc_sort_handler's 23 sort/reorder modes (gray/white/primary-to-top, HSI/HSL/HSV/L/Rec.709-luma/RGB/BGR sorts, "minimize display response delay", and the interleave/checkerboard patterns) to the Qt testchart editor, which the module's own docstring explicitly flagged as deferred.DisplayCAL.cgats.CGATSsort/checkerboard methods, so no new sorting logic was needed, only the missing UI wiring._update_sort_controls().DisplayCAL/VERSIONto3.10.0.dev44.Closes #843.
Test plan
tests/test_ui_testchart_editor_patch_order.py(31 new tests): dispatch for every one of the 23 modes, enable/disable gating, grid refresh,modifiedflag.tests/test_ui_testchart_editor.py+tests/test_CGATS.pystill pass (no regressions).