Skip to content

[Qt] Colorimeter correction web-check dialog columns aren't sortable #958

Description

@eoyilmaz

Summary

In the Qt UI, the "Check online for colorimeter correction..." dialog shows the matching corrections in a table, but the columns aren't sortable. Clicking a column header does nothing, so with several results the user has to scan the whole table manually instead of sorting by, say, ΔE*00 avg/max or created date.

Location

_WebCheckChooserDialog in colorimeter_correction_io.py builds a QTableWidget (table = QTableWidget(len(rows), len(headers), self)) but never calls setSortingEnabled(True), and populates cells with plain string QTableWidgetItems, so a naive sort would also sort the ΔE*00/numeric columns lexicographically rather than numerically.

Expected behavior

Clicking a column header in the dialog should sort the table by that column, ascending/descending on repeated clicks, matching normal Qt table conventions. Numeric columns (fit_avg_de00, fit_max_de00) should sort numerically, not as strings.

Notes

This is a new Qt feature gap, not a regression from the wx UI (need to double check whether the wx equivalent dialog supports sorting for parity).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions