feat: Convert per-repo weight from unbounded multiplier to emission_share#1223
Closed
jonathanchang31 wants to merge 1 commit into
Closed
feat: Convert per-repo weight from unbounded multiplier to emission_share#1223jonathanchang31 wants to merge 1 commit into
jonathanchang31 wants to merge 1 commit into
Conversation
789af1a to
b985429
Compare
10 tasks
10 tasks
Collaborator
|
Issue #1215 deliverables missed: D7 (SQL schema changes ship without a migration script), D11 (within-repo spill tested in only one direction; spec says 'vice versa'), D6 (no issue_discovery_share=0 short-circuit test). Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This update changes repository allocation from per-PR
weightmultiplier to per-repoemission_sharepool slicing.RepositoryConfig.weight→RepositoryConfig.emission_share([0,1])RepositoryConfig.issue_discovery_share([0,1], default0.5)sum(emission_share) <= 1.0allocate-then-distribute)1 - sum(emission_share))OSS_EMISSION_SHARE = 0.90ISSUES_TREASURY_EMISSION_SHARE = 0.10RECYCLE_EMISSION_SHAREbaselineRelated Issue
Closes: #1215
Change Type (select all)
Real Behavior Proof
Use these expected outcomes as acceptance checks:
All repos active,
sum(emission_share)=1.090%10%0%No activity on any repo,
sum(emission_share)=1.00%10%90%All repos active,
sum(emission_share)=0.872%(0.9 * 0.8)10%18%(registry slack)Repo with
issue_discovery_share=0.3, PR active, issue inactiveRepo has no eligible nonzero scorers on both sides