fix(mirror): skip fixed-base scoring when PR file evidence is unavailable#1204
Closed
Desel72 wants to merge 1 commit into
Closed
fix(mirror): skip fixed-base scoring when PR file evidence is unavailable#1204Desel72 wants to merge 1 commit into
Desel72 wants to merge 1 commit into
Conversation
10 tasks
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent awarding fresh mirror OSS score from
fixed_base_scorewhen PR file evidence is unavailable in the current round.Before this change,
score_mirror_prcould still applyfixed_base_scoreafter:MirrorRequestError, orscoring_data_stored=True.That allowed nonzero earned score with zero token evidence for the round.
This PR changes that behavior to skip scoring that PR for the round when file evidence is unavailable, even in fixed-base repositories.
Related Issues
Closes #1203
Type of Change
Testing
Added regression tests in mirror scoring suite:
MirrorRequestErroronget_pr_files=> no fresh scorescoring_data_stored=True=> no fresh scoreValidation notes:
python3 -m py_compilepassed for modified files.bittensor.Checklist