fix: parse GraphQL response JSON once per PR page (#1056)#1060
Closed
alpurkan17 wants to merge 1 commit into
Closed
fix: parse GraphQL response JSON once per PR page (#1056)#1060alpurkan17 wants to merge 1 commit into
alpurkan17 wants to merge 1 commit into
Conversation
Get GraphQLPageResult carries already-parsed dict instead of raw Response. load_miners_prs consumes result.data directly, eliminating redundant response.json() call that doubled JSON-decode work every scoring round. - Change GraphQLPageResult.response -> GraphQLPageResult.data - get_github_graphql_query returns parsed data on success - load_miners_prs uses result.data instead of result.response.json() - RESOURCE_LIMITS_EXCEEDED detection still works via pre-parse check
|
@alpurkan17 |
Collaborator
|
Duplicate of #1055 which is better scoped/implemented. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get GraphQLPageResult carries already-parsed dict instead of raw Response. load_miners_prs consumes result.data directly, eliminating redundant response.json() call that doubled JSON-decode work every scoring round.