feat(miners): add search input to repository miner list - #1243
Conversation
8a23b3e to
f279f81
Compare
anderdc
left a comment
There was a problem hiding this comment.
Don't add a new file for this — inline the search input, matching the pattern the PR description itself cites.
TopRepositoriesTable.tsx (line 738) builds its search box as an inline searchInput const — a DebouncedSearchInput wrapping a TextField — directly in the component; LanguageWeightsTable, MinerPRsTable, IssuesList and others do the same. MinerSearchInput.tsx is a 61-line single-use file that duplicates that inline block near-verbatim and is consumed only by TopMinersTable.
- Delete src/components/leaderboard/MinerSearchInput.tsx and its import in TopMinersTable.tsx.
- Expand the searchInput const already added to TopMinersTable.tsx into the full DebouncedSearchInput / TextField / ClearSearchAdornment JSX, same as TopRepositoriesTable.tsx line 738.
|
@anderdc Ready for review |
|
Holding this in the review queue until the changes @anderdc requested are addressed. Once you've pushed updates, please re-request review and we'll take another pass. |
|
@ventura-oss @e35ventura I've already fixed based on the @anderdc feedback. |
Summary
The Miners tab on the repository details page had no search input — users had to scroll the list (often 100+ entries) to find a specific miner. The URL
searchparam and the GitHub-ID/author filter logic were already wired up inTopMinersTable.tsx(lines 350–357); only the visible input was missing.This PR adds a debounced search
TextFieldtoTopMinersTable, reusing the existingDebouncedSearchInputandClearSearchAdornmentprimitives — same pattern asTopRepositoriesTable.Related Issues
Closes #1244
Type of Change
Screenshots
Record_2026_05_19_20_09_36_463.mp4
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses