fix(miners): sort pull requests by state-relevant timestamp instead of created_at#155
Open
Tet-9 wants to merge 1 commit into
Open
fix(miners): sort pull requests by state-relevant timestamp instead of created_at#155Tet-9 wants to merge 1 commit into
Tet-9 wants to merge 1 commit into
Conversation
…f created_at Both getPullRequests and getPullRequestsByRepo sorted all results by p.created_at DESC regardless of PR state. A PR opened 60 days ago but closed 2 days ago would appear below PRs opened more recently, making CLOSED results appear stale to validators. Fix both ORDER BY clauses to use COALESCE(p.merged_at, p.closed_at, p.created_at) DESC so each PR floats by the timestamp most relevant to its state. Also fixes the CLOSED filter to use closed_at >= since consistent with entrius#139. Fixes entrius#151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(miners): sort pull requests by state-relevant timestamp instead of created_at
Summary
getPullRequestsandgetPullRequestsByRepoinminers.service.tssorted all pull request results byp.created_at DESCregardless of PR state. A PR opened 60 days ago but closed 2 days ago would appear near the bottom of results behind PRs opened more recently, making recently-resolved CLOSED PRs appear stale to validators.Root Cause
Both query variants used a single fixed sort key for all states:
-- Before (incorrect)
ORDER BY p.created_at DESC
-- After (correct)
ORDER BY COALESCE(p.merged_at, p.closed_at, p.created_at) DESC
This is inconsistent with how the filter already distinguishes between states (merged_at for MERGED, closed_at for CLOSED after #139). The sort should reflect the same timestamp hierarchy.
Changes
Testing
Lint confirmed only pre-existing errors in cache.module.ts, unrelated to this change. Verified ORDER BY on issue query variants (lines 278, 321) were not affected.
Fixes #151