fix(webhook): fail missing PR file content blobs#148
Open
JSONbored wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
GitHub GraphQL can return
nullforobject(expression: ...)without top-levelerrors. A live probe against this repo confirms that a missing object expression returns:{"data":{"repository":{"missingObject":null}}}Before this change, a modified text file could be stored with a missing required head or base blob as trusted
nullcontent. That lets the file fetch complete even though a required file-content input was absent.This keeps the existing retry/failure path responsible for incomplete PR file content instead of persisting an incomplete row as if it were valid.
Prior context
headShaand exhausted GraphQL batch failures. This covers the remaining successful-response case where an individual required GraphQL alias resolves tonull.errorsfail. This handles the no-errors, null-alias shape separately.No existing issue or PR was found for this exact per-alias GraphQL null-object case.
Type of Change
Testing
npm run format:checknpm run lintnpm run buildgit diff --checknullthrows before any content upsertobject(expression: ...)returnsnullwithout top-levelerrorsChecklist