fix(fuses): correct checkPccBurned logic to check for burned fuse#294
Open
madisoncarter1234 wants to merge 1 commit intoensdomains:mainfrom
Open
fix(fuses): correct checkPccBurned logic to check for burned fuse#294madisoncarter1234 wants to merge 1 commit intoensdomains:mainfrom
madisoncarter1234 wants to merge 1 commit intoensdomains:mainfrom
Conversation
The function was checking === 0n which returns true when the fuse is NOT set. Fixed to check === PARENT_CANNOT_CONTROL to correctly return true when the fuse IS burned. Added tests to prevent regression. Fixes ensdomains#268
madisoncarter1234
requested review from
storywithoutend and
svemat01
as code owners
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkPccBurnedfunction which was returning the opposite of its intended result=== 0n(true when fuse is NOT set) instead of=== PARENT_CANNOT_CONTROL(true when fuse IS set/burned)The Bug
Test Plan
checkPccBurnedfunctionFixes #268