Feat/wna server by azam-ismail · Pull Request #35 · energywebfoundation/ewx-worker-node-server

azam-ismail · 2026-01-15T07:51:17Z

No description provided.

hejkerooo · 2026-01-15T07:58:54Z

+
+const adminLogger = createLogger('Admin');
+
+export const createAdminRouter = (): express.Router => {


those endpoints can be called by smartflows, can we make separate http server for it? We need to consider additional security layer here so no one can randomly stop instance

hejkerooo · 2026-01-15T08:00:28Z

+        });
+
+        // Perform graceful shutdown after response is sent
+        setTimeout(() => {


I really dislike this setTimeout. Can you send SIGTERM and add event handler on it?

hejkerooo · 2026-01-15T08:00:51Z

  };
 };
+
+const getOperatorInfo = async (timeoutMs: number = 5000): Promise<OperatorInfo | undefined> => {


move it to different place and export as public method

hejkerooo · 2026-01-15T08:01:17Z

 | `LOCAL_SOLUTIONS_PATH`         | Path to locally hosted NodeRed solution flow files to be used when installing solutions using "local" prefix within WorkLogic field.                                                                  | `string`               |                                                          |
 | `SS58_FORMAT`                  | SS58 Key Format.                                                                                                                                                                                      | `number` (_>0_)        | `42`                                                     |
 | `PRETTY_PRINT`                 | Should pretty print logs. If you plan to use Grafana or any other log tooling it's recommended to set it to false.                                                                                    | `'true' \| 'false'`    | `'false'`                                                |
+| `LOG_FILE_PATH`                | Full path to log file (e.g., /var/log/app.log or ./logs/app.log)                                                                                                                                      | `string`               |                                                          |


If value is not provided it means that log file transport is disabled

hejkerooo · 2026-01-15T08:02:38Z

  };
 };
+
+const getOperatorInfo = async (timeoutMs: number = 5000): Promise<OperatorInfo | undefined> => {


instead of undefined please use null, it's more explicit

hejkerooo · 2026-01-15T08:03:24Z

+          return {
+            id: solution.solutionId,
+            name,
+            status: 'Active', // Assume active if installed


hejkerooo · 2026-01-15T08:03:41Z

+      solutionGroups,
+    };
+  } catch {
+    return undefined;


at least print error so we know what is going on

hejkerooo · 2026-01-15T08:05:14Z

+export const getAllInstalledSolutionsWithGroups = async (): Promise<InstalledSolutionDetails[]> => {
+  const tabNodes = await getTabNodes();
+
+  const solutions: Array<InstalledSolutionDetails | null> = await Promise.all(


why you need Promise.all ?

hejkerooo · 2026-01-15T08:06:07Z

+  return logPath;
+};
+
+const ensureLogDir = (logPath: string): void => {


ensureLogDirExists

hejkerooo · 2026-01-15T10:28:12Z

@@ -0,0 +1,46 @@
+import express from 'express';
+import { createLogger } from '../util/logger';
+import { getIsShuttingDown } from '../shutdown';


Can you create a middleware that will not accept new requests?

It can be even applied to submit vote endpoint so we don't accept new votes in case

hejkerooo · 2026-01-29T10:03:03Z

+  // Gather configuration (non-sensitive)
+  let rpcUrl: string | undefined;
+  let workerAddress: string | undefined;
+  try {


app should not initialize without worker address but it's ok.

I don't see a point to assign rpcUrl in both places, why not just const rpcUrl = MAIN_CONFIG.PALLET_RPC_URL ? We don't even need to reassign it, just use it in return

updated https://github.com/energywebfoundation/ewx-worker-node-server/pull/35/changes#r2744947141

hejkerooo · 2026-01-29T10:04:14Z

+  }
+
+  // Get operator information with solution groups
+  const operatorInfo = await getOperatorInfo();


This logic does not make sense to me, first there is a try-catch that I assume checks if worker address is present and then you fetch operator info based on worker address without any additional checks?

Please clean up this logic as it's confusing

updated check top logic

hejkerooo · 2026-01-29T10:08:22Z

+      : {}),
+  };
+
+  const cacheKey = `file:${JSON.stringify(options)}`;


Can you make maybe hash out of this JSON stringify? It's not cheap operation

https://www.npmjs.com/package/object-hash
Maybe use this but let's ensure that it will work as expected for our use case

hejkerooo · 2026-01-29T10:08:33Z

+    translateTime: 'SYS:HH:MM:ss',
+  };
+
+  const cacheKey = `pretty:${JSON.stringify(options)}`;


Same as above

hejkerooo · 2026-01-29T10:11:03Z

+      () => null,
+    );
+
+    await api.disconnect().catch(() => {


It needs to be in some finally block so we are sure it will execute and not lost

hejkerooo · 2026-01-29T10:13:33Z

+const logger = createLogger('OperatorAddressCache');
+
+// In-memory cache: Map<workerAddress, operatorAddress>
+const operatorAddressCache = new Map<string, string>();


Operator of worker might be changed while WNS is still running so it will return incorrect information.

Please add some cache expiration, ideally you could use https://www.npmjs.com/package/cache-manager

hejkerooo · 2026-01-29T10:15:24Z

+
+// Extracts solution name, removing UUID suffix if present
+const extractSolutionName = (solutionId: string): string => {
+  const lastDot = solutionId.lastIndexOf('.');


What is the use case? It looks like it's for some very specific use case, can you describe that one? In some cases it might lead to undefined-behavior.

put in func description

azam-ismail · 2026-01-30T07:04:38Z

  };
 };
+
+export const getSolutionGroupsDetailsStatus = async (): Promise<SolutionGroupsDetailsStatus> => {


azam-ismail requested a review from kim-energyweb January 15, 2026 07:51

azam-ismail requested a review from hejkerooo as a code owner January 15, 2026 07:51

azam-ismail changed the base branch from master to feat/auth January 15, 2026 07:52

feat: enable file logger

902b1f6

azam-ismail force-pushed the feat/wna-server branch from 4d7c708 to 227e07b Compare January 15, 2026 08:42

azam-ismail added 2 commits January 15, 2026 17:43

feat: admin stop and shutdown endpoint

94ee983

feat: endpoint to get solution group details

37786f7

azam-ismail force-pushed the feat/wna-server branch from 227e07b to 37786f7 Compare January 15, 2026 09:43

hejkerooo reviewed Jan 16, 2026

View reviewed changes

fix: admin stop, health endpoint

cd79ed8

azam-ismail requested a review from hejkerooo January 19, 2026 07:18

hejkerooo reviewed Jan 29, 2026

View reviewed changes

fix: enable cache and hash

08b852c

azam-ismail requested a review from hejkerooo January 30, 2026 04:00

hejkerooo approved these changes Jan 30, 2026

View reviewed changes

azam-ismail commented Jan 30, 2026

View reviewed changes

azam-ismail merged commit 3262629 into feat/auth Jan 30, 2026
2 checks passed


		const adminLogger = createLogger('Admin');

		export const createAdminRouter = (): express.Router => {

Conversation

azam-ismail commented Jan 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azam-ismail Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

azam-ismail Jan 30, 2026 •

edited

Loading