Documentation update related module deactivation in Helmchart#5577
Open
alexvaque wants to merge 1 commit intoemissary-ingress:masterfrom
Open
Documentation update related module deactivation in Helmchart#5577alexvaque wants to merge 1 commit intoemissary-ingress:masterfrom
alexvaque wants to merge 1 commit intoemissary-ingress:masterfrom
Conversation
Signed-off-by: Alex Vaque <a.vaque@sportradar.com>
a70aca0 to
717e250
Compare
Author
|
Hi @alexgervais or @AliceProxy, I noticed that you are listed as project maintainers. Could we please merge this README update? It is a basic change in the code comments nothing else The documentation has been somewhat confusing as it suggests using module: {} for module deactivation using the Helmchart. However, after conducting personal tests, I found that deactivating the module is achieved with module: false. To prevent further confusion, I have updated the README accordingly. Thank you. |
bashlion
approved these changes
Jan 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
about module deactivation in Helmchart the documentation saids that we need to disable module with
module: {}but must be
module: falseRelated Issues
List related issues.
Testing
I deployed in my infrastructure
module: {}but this did not work
Checklist
Does my change need to be backported to a previous release?
I made sure to update
CHANGELOG.md.Remember, the CHANGELOG needs to mention:
This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:
My change is adequately tested.
Remember when considering testing:
I updated
DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.The changes in this PR have been reviewed for security concerns and adherence to security best practices.