Fix table column resize handle double-click auto-size when id_salt is set#7896
Open
ahundt wants to merge 2 commits intoemilk:mainfrom
Open
Fix table column resize handle double-click auto-size when id_salt is set#7896ahundt wants to merge 2 commits intoemilk:mainfrom
ahundt wants to merge 2 commits intoemilk:mainfrom
Conversation
… set
The double-click detection loop in `show_generated` constructed widget
IDs using `ui.id().with("resize_column").with(i)`, but the actual
resize handle widgets were created with
`state_id.with("resize_column").with(i)` where `state_id = ui.id().with(id_salt)`.
When a table uses `id_salt` (common when multiple tables exist in the
same Ui), these IDs never match, so `read_response()` never finds the
resize handle's interactions. This made double-click auto-fit
completely non-functional for any table with an `id_salt`.
Fix: move the `state_id` initialization before the double-click
detection loop and use `state_id` instead of `ui.id()` for the
widget ID, matching what the resize handle widget uses.
Create a resizable two-column table with id_salt set, simulate a double-click on the column separator (resize handle), and verify the first column auto-sizes to fit its content. The test uses a small step_dt (0.05s) because egui_kittest processes each event in its own frame — with the default 0.25s step_dt, two clicks span 4 frames (1.0s), exceeding the 0.3s double-click threshold. Without the fix in the preceding commit, this test fails because the mismatched widget IDs prevent read_response() from detecting the double-click on the resize handle.
|
Preview is being built... Preview will be available at https://egui-pr-preview.github.io/pr/7896-fix/table-column-separator-double-click-id-salt View snapshot changes at kitdiff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id_saltis setshow_generatedconstructed widget IDs usingui.id().with("resize_column").with(i), but the resize handle widgets usedstate_id.with("resize_column").with(i)wherestate_id = ui.id().with(id_salt)— these never matched, soread_response()never found the interactionstate_idinitialization before the loop and use it for the widget IDid_salt, simulates a double-click on the column separator, and verifies the column auto-sizesTest plan
cargo clippyclean