Remove <title> from index.html upon install if ember-page-title is present#794
Open
raido wants to merge 2 commits intoember-fastboot:masterfrom
Open
Remove <title> from index.html upon install if ember-page-title is present#794raido wants to merge 2 commits intoember-fastboot:masterfrom
raido wants to merge 2 commits intoember-fastboot:masterfrom
Conversation
raido
force-pushed
the
blueprint-removes-title-element
branch
from
20a1b2c to
8f13be6
Compare
raido
force-pushed
the
blueprint-removes-title-element
branch
from
8f13be6 to
417437b
Compare
SergeAstapov
approved these changes
May 28, 2022
Contributor
|
this looks good although would be great to have a test case added to ensure it works as expected and not regressed moving forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counter part PR on ember-page-title side is already merged - ember-cli/ember-page-title#177
And here is a follow up on ember-page-title side - ember-cli/ember-page-title#179
Closes #792.