Skip to content

#2557 Support cell conditions to focus error message on a nested row#2558

Open
caritaou wants to merge 17 commits intoelyra-ai:mainfrom
caritaou:cou-nested-cell-conditions
Open

#2557 Support cell conditions to focus error message on a nested row#2558
caritaou wants to merge 17 commits intoelyra-ai:mainfrom
caritaou:cou-nested-cell-conditions

Conversation

@caritaou
Copy link
Copy Markdown
Member

@caritaou caritaou commented May 22, 2025

closes #2557

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

caritaou added 15 commits May 22, 2025 09:37
…ted row

Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Carita Ou <cou@us.ibm.com>
Signed-off-by: Carita Ou <cou@us.ibm.com>
@nmgokhale
Copy link
Copy Markdown
Member

  1. When 2 cells in the table has error, only latest error message is shown below table -

In other tables, it shows the error as There are 'n' error cells.
Screenshot 2025-06-02 at 10 20 17 AM

  1. In structurelisteditor_paramDef, there's an example of 3 level nesting. Is it possible to add a similar example of 3 level nesting in nestedConditions_paramDef?

Signed-off-by: Carita Ou <cou@us.ibm.com>
@caritaou
Copy link
Copy Markdown
Member Author

caritaou commented Jun 2, 2025

  1. When 2 cells in the table has error, only latest error message is shown below table -

Thanks for catching this, I missed this case

  1. In structurelisteditor_paramDef, there's an example of 3 level nesting. Is it possible to add a similar example of 3 level nesting in nestedConditions_paramDef?

Right now the new code will only support up to cell conditions 2 columns deep. There will need to be additional code changes for 3 levels to parse the condition paremeter_ref. Since there hasnt been a need for this yet, I haven't tested it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support cell conditions to focus the error message on a nested row

2 participants