Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
@dotnet-policy-service agree |
There was a problem hiding this comment.
Pull request overview
This pull request adds support for .NET 10.0 as a target framework across the Elsa Workflows codebase. The changes systematically update project files to include net10.0 alongside existing net8.0 and net9.0 targets, and add conditional package references for .NET 10.0-compatible versions of dependencies.
Changes:
- Added
net10.0to TargetFrameworks in 43 project files across server, persistence, modules, activities, and designer components - Added conditional ItemGroups with .NET 10.0-compatible package versions (primarily Entity Framework Core 10.0.0, ASP.NET Core 10.0.0, and related Microsoft packages)
- Included a binary icon.png file update (unrelated to .NET 10 support)
Reviewed changes
Copilot reviewed 42 out of 43 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/server/Elsa.Server.Api/Elsa.Server.Api.csproj | Added net10.0 target and updated MVC/Linq packages |
| src/samples/persistence/Elsa.Samples.Persistence.EntityFramework/Elsa.Samples.Persistence.EntityFramework.csproj | Added net10.0 System.Text.Encodings.Web package |
| src/persistence/Elsa.Persistence.EntityFramework./Elsa.Persistence.EntityFramework..csproj (5 files) | Added net10.0 target and EF Core 10.0.0 packages for all database providers |
| src/modules/workflowtesting//Elsa.WorkflowTesting.csproj (2 files) | Added net10.0 target framework |
| src/modules/workflowsettings/Elsa.WorkflowSettings.*.csproj (7 files) | Added net10.0 target and appropriate EF Core 10.0.0 packages |
| src/modules/secrets/Elsa.Secrets.*.csproj (7 files) | Added net10.0 target and updated dependencies |
| src/designer/bindings/aspnet/Elsa.Designer.Components.Web/Elsa.Designer.Components.Web.csproj | Added net10.0 ASP.NET Core Components package |
| src/activities/webhooks/Elsa.Webhooks.*.csproj (7 files) | Added net10.0 target and EF Core packages |
| src/activities/Elsa.Activities./Elsa.Activities..csproj (6 files) | Added net10.0 target and required packages |
| icon.png | Binary file update (unrelated to .NET 10 support) |
...sistence.EntityFramework.SqlServer/Elsa.Secrets.Persistence.EntityFramework.SqlServer.csproj
Show resolved
Hide resolved
...amework/Elsa.Persistence.EntityFramework.MySql/Elsa.Persistence.EntityFramework.MySql.csproj
Show resolved
Hide resolved
...oks.Persistence.EntityFramework.MySql/Elsa.Webhooks.Persistence.EntityFramework.MySql.csproj
Show resolved
Hide resolved
...amework/Elsa.Persistence.EntityFramework.MySql/Elsa.Persistence.EntityFramework.MySql.csproj
Show resolved
Hide resolved
...oks.Persistence.EntityFramework.MySql/Elsa.Webhooks.Persistence.EntityFramework.MySql.csproj
Show resolved
Hide resolved
...istence.EntityFramework.MySql/Elsa.WorkflowSettings.Persistence.EntityFramework.MySql.csproj
Show resolved
Hide resolved
|
@sfmskywalker Hello. Can you review/approve this PR? |
#7184