ISSUE-FR #779 - Added UI separator to indicate the start of a new mon…#1014
Open
abiding9072 wants to merge 1 commit intoellite:mainfrom
Open
ISSUE-FR #779 - Added UI separator to indicate the start of a new mon…#1014abiding9072 wants to merge 1 commit intoellite:mainfrom
abiding9072 wants to merge 1 commit intoellite:mainfrom
Conversation
…ew month of subscriptions at a glance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made changes to address this feature request I opened a while back.
#779
Tested and compiled a docker image on my end and confirmed as working.
CHANGES ::
[includes/list_subscriptions.php] :- Added month boundary detection in printSubscriptions. When sort order is next_payment, a separator is inserted between consecutive subscriptions whose next_payment dates fall in different months.
[subscriptions.php] :- Added $print[$id]['next_payment_raw'] to carry the raw DB date string alongside the formatted display date. Added && !$subscription['inactive'] to ensure that the separator is never inserted before (or between) disabled subscriptions, only active ones.
[endpoints/subscriptions/get.php] :- Same raw date addition for the AJAX-fetched subscription list (used after add/edit/delete/filter operations).
[styles/styles.css] :- Added .month-separator CSS class: a half sized and centered horizontal line using the theme's accent color (matches whatever color theme the user has selected) with slight opacity.
The separator only appears when sorted by next payment date (the default sort).
WORKING DEMO ::