Conversation
- 在 report_generator.py 中添加 GDAF 运行代码（项目模式） - 添加辅助方法 _resolve_gdaf_context 和 _resolve_bom_directory - 在 generate_global_project_report 中复制 gdaf_scenarios 到 dummy_model - 在 export_service.py 中删除重复的 GDAF 代码（已移到 report_generator）
Addresses code duplication identified in PR ellipse2v#21 review. The _resolve_gdaf_context() and _resolve_bom_directory() methods were duplicated across ExportService and ReportGenerator. This change extracts both methods to threat_analysis/utils.py as standalone functions and updates both services to import from there. Benefits: - Single source of truth for path resolution logic - Easier maintenance - changes apply to both services - Prevents future drift between duplicate implementations - Follows DRY principle The generate_global_project_report() method now includes a comment documenting the ordering invariant for all_models[0] being the main threat model, as recommended in the review. Also updated AIService._load_model_context() docstring to reference the new location of the resolution logic. Refs: PR ellipse2v#21
|
hi @zhangtianqi-james hi think it's the same PR as PR21 with a rebase ? is it a mistake ? what do you think about the tool ? what do you want to have ? thanks regards |
|
Hi @ellipse2v, I sincerely apologize for this confusion. This PR was created unintentionally due to a misunderstanding of GitHub's fork synchronization mechanism. What happened:
Resolution:
What I'm doing:
I take full responsibility for this mistake and apologize for any confusion or noise it may have caused. I truly appreciate the work you do maintaining this project, and I'm sorry for the inconvenience. |
|
Hey @zhangtianqi-james I really appreciate your involvement. I'm looking for people who are able to test the tool, put it through its paces in real-world scenarios, and help identify what can be improved — so please don't hesitate to keep exploring the project. Thanks for the clear explanation and for cleaning things up so quickly. See you around on the project! |
2 participants
No description provided.