[FCE-3217] Fix unhandled ExTURN expiry messages#102
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 87.15% 87.17% +0.02%
==========================================
Files 27 27
Lines 2078 2082 +4
==========================================
+ Hits 1811 1815 +4
Misses 267 267
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
roznawsk
requested changes
May 8, 2026
| end | ||
|
|
||
| @spec handle_ex_turn_msg(t(), reference(), ExTURN.Client.notification_message()) :: t() | ||
| @spec handle_ex_turn_msg(t(), reference(), term()) :: t() |
Member
There was a problem hiding this comment.
The ExTurn.Client exports this type:
@typedoc """
Messages that can be passed to `handle_message/2`.
"""
@type message() ::
{:socket_data, :inet.ip_address(), :inet.port_number(), binary()}
| internal_notification_message()
which is used by the handle_message function:
@spec handle_message(t(), message()) :: on_handle_message()
we could use this type instead.
Member
There was a problem hiding this comment.
btw you can bump the ex_turn to 0.2.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #99