refactor(radio-speaker): replace useMemo with memo for preventing component re-rendering #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I replaced
useMemowithmemo()forSpeakerControls.The previous implementation used
useMemoto memoize JSX:This is unconventional because:
I noticed that although we define
classas a prop, it isn’t used anywhere in the code.After inspecting the component, it seems this isn’t intended for developers to use directly.
Additional information
Because this project uses React 19, we can enable the compiler and we remove all these caching hooks and HOC (
useMemo,memo,useCallback).