refactor(audio-player): extract inline events implementation from JSX for readability #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In the
AudioPlayercomponent, the events logic are defined directly within the JSX.While this works technically, it reduces readability and makes testing more difficult, as developers may struggle to understand the component’s structure and the relationship between the code and the UI.
Additionally, we were checking the negated condition before the positive one in this part of the code:
ESLint detects this as an issue with the no-negated-condition rule.
It’s recommended to check the positive condition first: