Skip to content

EntryPopover/DateTime: cleanup and GTK4 prep #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 1 commit into from
Mar 6, 2025
Merged

EntryPopover/DateTime: cleanup and GTK4 prep #404

danirabbit merged 1 commit into from
Mar 6, 2025

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Mar 6, 2025

Minor but slightly reduces diff to port to GTK4

  • Use child property
  • clicked instead of button release event
  • Minor codestyle while here

@danirabbit danirabbit requested a review from a team March 6, 2025 22:16
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Mar 6, 2025
@danirabbit danirabbit merged commit 222371e into master Mar 6, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in GTK4 Porting Mar 6, 2025
@danirabbit danirabbit deleted the danirabbit/datetime-cleanup branch March 6, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lenemter lenemter lenemter approved these changes

Assignees

No one assigned

Labels

None yet

Projects

GTK4 Porting
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @lenemter