variant,tuple: fix/silence misc warnings#564
Open
virt00l wants to merge 1 commit intoelectronicarts:masterfrom
Open
variant,tuple: fix/silence misc warnings#564virt00l wants to merge 1 commit intoelectronicarts:masterfrom
virt00l wants to merge 1 commit intoelectronicarts:masterfrom
Conversation
virt00l
force-pushed
the
variant-silence-msvc-c5267
branch
from
69457ac to
abe6ba5
Compare
msvc: https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c5267 Similar to neighboring C4625 Fix for warnings (errors in /WX mode) like .../variant.h(759): warning C5267: definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor (ditto for tuple). Also fix for -Wunused-parameter in variant.h (`visit_throw_bad_variant_access`)
virt00l
force-pushed
the
variant-silence-msvc-c5267
branch
from
abe6ba5 to
91dff36
Compare
virt00l
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
variant,tuple: fix/silence misc warnings
msvc:
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c5267
Similar to neighboring C4625
Fix for warnings (errors in /WX mode) like
.../variant.h(759): warning C5267: definition of implicit copy constructor for '...' is deprecated because it has a user-provided destructor
(ditto for tuple).
Also fix for -Wunused-parameter in variant.h (
visit_throw_bad_variant_access)