Skip to content

Fix RPM spec install copy path for rpm 4.20+ #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keyboard2005 wants to merge 1 commit into from
+1 −1
Closed

Fix RPM spec install copy path for rpm 4.20+ #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/spec.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ print('\n\n\n') }

%>%install
mkdir -p %{buildroot}/usr/
cp <%= process.platform === 'darwin' ? '-R' : '-r' %> usr/* %{buildroot}/usr/
cp <%= process.platform === 'darwin' ? '-R' : '-r' %> %{_topdir}/BUILD/usr/* %{buildroot}/usr/
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corresponding test fixture file test/fixtures/custom.spec.ejs at line 23 still uses the old path pattern usr/* instead of %{_topdir}/BUILD/usr/*. For consistency and to ensure tests validate the correct behavior with rpm 4.20+, this should be updated to match the fix in the main spec template.

Copilot uses AI. Check for mistakes.


%files
Expand Down
Loading