chore(deps): bump commerce-elastic-path to 0.5.1 in canvas-packages, loader-bundle-env and the example app - #513
Merged
Conversation
…loader-bundle-env and the example app 0.5.1 restores the component whose removal in 0.5.0 makes publish-hostless fail (#512). The `^0.5.0` ranges already allowed 0.5.1, but all three lockfiles pinned the resolved version at 0.5.0 and publish-hostless installs with --frozen-lockfile, so it would have installed 0.5.0 again and failed the same way. Ranges moved to ^0.5.1 as well, to record the real floor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@elasticpath/plasmic-ep-commerce-elastic-path0.5.1 restores a component whose removalin 0.5.0 made
publish-hostlessfail outright (see #512). Three consumers need to resolveit before that job can succeed.
The version ranges already allow it —
^0.5.0means>=0.5.0 <0.6.0, so 0.5.1 satisfiesthem. The problem is the lockfiles: all three pin the resolved version at exactly 0.5.0,
and
publish-hostlessrunsyarn install --frozen-lockfile, so it would install 0.5.0again and hit the same failure.
platform/canvas-packages— components the Studio canvas renders, and whatpublish-hostlessbuilds fromplatform/loader-bundle-env— the bundle the loader/renderer servesexamples/ep-commerce-app-router— reference storefrontEach is a separate yarn project, so each lockfile is regenerated in its own directory. The
ranges are also bumped to
^0.5.1— not strictly required, but it records the real floorso a later
yarn installcannot quietly resolve 0.5.0 again.Note
deploy-integration.ymltriggers onplatform/wab/**,platform/loader-bundle-env/**and
.github/**— not onplatform/canvas-packages/**. The loader-bundle-env change inthis PR triggers the deploy; a canvas-packages-only change would not.