Conversation
pquentin
reviewed
Sep 27, 2023
pquentin
left a comment
pquentin
left a comment
Member
There was a problem hiding this comment.
Since elastic/elasticsearch#97397 does not work in practice, I'm a bit reluctant to add this until we can prove it works. That said, the code looks good, so I'm happy to merge it if you prefer.
Member
Author
|
I have no problem waiting to merge. |
Member
Author
|
Closing this since it's so old. |
Member
|
Sorry that I did not look into it yet, but I haven't totally given up on this. 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
410 GoneHTTP response status, so a more useful exception is raised when an Elasticsearch API is unavailable. See elastic/elasticsearch#97397.