Add data source switch on album search results page#276
Merged
elamperti merged 3 commits intoelamperti:mainfrom Apr 19, 2026
Merged
Add data source switch on album search results page#276elamperti merged 3 commits intoelamperti:mainfrom
elamperti merged 3 commits intoelamperti:mainfrom
Conversation
* New `ProviderItem` component handles data source in the album search results breadcrumb, including new optional dropdown display. * Update `AlbumBreadcrumb` with new `showProviderDropdown` prop which gets passed to `ProviderItem`.
* New cypress tests for new data source dropdown and switching functionality
Owner
|
hey, sorry I didn't get to reply to your issue earlier. This is a good idea and the PR looks good! I'll test it later and merge if everything is ok. Thanks for your contribution! 😊 |
elamperti
force-pushed
the
main
branch
9 times, most recently
from
dda723a to
bcf28c3
Compare
elamperti
approved these changes
Apr 19, 2026
Owner
elamperti
left a comment
elamperti
left a comment
There was a problem hiding this comment.
Looks great! Sorry it took me long to merge, I wanted to fix the CI pipeline first. I've been testing this locally and works as expected. Thanks again for this PR! This feature will be included in the next release 👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After searching for an album, the data source can only be changed by going back to the search form.
On the album results page, the static display of the data source has been changed to a dropdown to facilitate switching. After selecting an album, it goes back to the static text, as switching data sources at this point doesn't really make sense.
Addresses #275.
Changes
src/domains/scrobbleAlbum/partials/ProviderItem.tsxshowDropdownpropsrc/domains/scrobbleAlbum/partials/AlbumBreadcrumb.tsxProviderItemto display the data sourceshowProviderDropdownthat gets passed toProviderItemsrc/domains/scrobbleAlbum/ScrobbleAlbumResults.tsxshowProviderDropdownonAlbumBreadcrumbto show the new dropdownAlbumBreadcrumbare unchanged and will show static textTests
cypress/e2e/scrobbleAlbum/scrobble-album-data-source.spec.jsI haven't worked with Cypress before, so please let me know if any changes are needed with the tests.