fix: don't set COPILOT_HOME, and provide MCP instructions instead#286
Open
wdconinc wants to merge 3 commits into
Open
fix: don't set COPILOT_HOME, and provide MCP instructions instead#286wdconinc wants to merge 3 commits into
wdconinc wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to stop setting COPILOT_HOME in the EIC container and instead expose Copilot custom instructions that point users toward MCP server configuration.
Changes:
- Replaces
COPILOT_HOMEsetup withCOPILOT_CUSTOM_INSTRUCTIONS_DIRS. - Adds a Copilot instructions Markdown file describing available EIC MCP servers and how to enable them.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
containers/eic/profile.d/z23_copilot_mcp.sh |
Sets the Copilot custom instructions directory to /etc/copilot unless already configured. |
containers/eic/copilot/mcp-config.instructions.md |
Adds instructions for enabling pre-installed MCP servers from user configuration. |
Removed specific MCP server configuration and updated the copy command to include the entire copilot directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Setting
COPILOT_HOMEto a read-only directory in the container interferes with copilot startup inside the container. Wrappers or startup commands were considered to be too fragile to implement, so we take an indirect approach instead and provide instructions to the client itself. This is also a more scalable approach for other types of instructions.What is the urgency of this PR?
What kind of change does this PR introduce?
COPILOT_HOMEfirst)Please check if any of the following apply
Currently copilot is not operational by default inside eic-shell.