DateTimeNormalizer should be registered for like for like comparison#11
Open
bendavies wants to merge 1 commit intoegeloen:masterfrom
bendavies:symfony-datetime-normalizer
Open
DateTimeNormalizer should be registered for like for like comparison#11bendavies wants to merge 1 commit intoegeloen:masterfrom bendavies:symfony-datetime-normalizer
bendavies wants to merge 1 commit intoegeloen:masterfrom
bendavies:symfony-datetime-normalizer
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symfony serializers weren't registering the
DateTimeNormalizer. Ivory and JMS have them built in, so we need to manually register it for symfony for a fair comparison.This improves the symfony bencharmk quite a bit.